Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: a better way to round scale factor when collecting TopN stats #49808

Merged
merged 3 commits into from
Dec 27, 2023
Merged

planner: a better way to round scale factor when collecting TopN stats #49808

merged 3 commits into from
Dec 27, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 26, 2023

What problem does this PR solve?

Issue Number: close #49801

Problem Summary: planner: a better way to round scale factor when collecting TopN stats

What changed and how does it work?

planner: a better way to round scale factor when collecting TopN stats

See #49801 for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 26, 2023
@tiprow tiprow
Copy link

tiprow bot commented Dec 26, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/retest

@tiprow tiprow
Copy link

tiprow bot commented Dec 26, 2023

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Merging #49808 (2541343) into master (5f6ef18) will increase coverage by 0.4435%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49808        +/-   ##
================================================
+ Coverage   70.9221%   71.3656%   +0.4435%     
================================================
  Files          1368       1429        +61     
  Lines        396367     415749     +19382     
================================================
+ Hits         281112     296702     +15590     
- Misses        95564     100247      +4683     
+ Partials      19691      18800       -891
Flag Coverage Δ
integration 43.9173% <100.0000%> (?)
unit 70.9221% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2311% <ø> (-5.6722%) ⬇️

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 27, 2023

/retest-required

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rustin170506
Rustin170506 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 👍

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 01:51:04.404707725 +0000 UTC m=+1616955.441934652: ☑️ agreed by hi-rustin.
  • 2023-12-27 02:21:24.752713808 +0000 UTC m=+1618775.789940730: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 1fb5a9a into pingcap:master Dec 27, 2023
18 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #49819.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#49808
114d58c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #49820.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#49808
ac1e785 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49821.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#49808
27a035e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
planner: a better way to round scale factor when collecting TopN stats (
cd073ea 
#49808) (#49819)

close #49801
ti-chi-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@ti-chi-bot
planner: a better way to round scale factor when collecting TopN stats (
14a7263 
#49808) (#49821)

close #49801
ti-chi-bot bot pushed a commit that referenced this pull request Feb 27, 2024
@ti-chi-bot
planner: a better way to round scale factor when collecting TopN stats (
f2927a5 
#49808) (#49820)

close #49801
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: incorrect cardinality estimation on composite indexes
5 participants
@qw4990 @wuhuizuo @ti-chi-bot @hawkingrei @Rustin170506